This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Expand location templates in container_run_and_extract rule. #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0walik
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
github-actions
bot
added
the
Can Close?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
container_run_and_extractrule accepts list of labels as the input arguments passed to the action running the container. We could elevate this information by applyingexpand_templatestodocker_run_flagsand pass generated files (i.e. environmental variables) as the input to the shell script that executes the action.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Location templates in
docker_run_flagsare passed todocker runcommands as literal strings.Issue Number: N/A
What is the new behavior?
Expand location templates before expanding shell script templates, so the paths to generated files are passed correctly.
Does this PR introduce a breaking change?
Other information